72358 - :table has border-spacing: 2px

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[Hixie (not reading bugmail)]

In html.css, the :table rule sets 'border-spacing' and 'border-collapse'.  It 
should inherit both of them.

I would guess we could change the rules like this:

========================= change this... =========

/* tables */

table, :table {
  display: table;
  border-spacing: 2px; 
  border-collapse: separate;
  margin-top: 0;
  margin-bottom: 0;
  -moz-box-sizing: border-box;
}

========================= to this... =============

/* tables */

table {
  display: table;
  border-spacing: 2px; 
  border-collapse: separate;
  margin-top: 0;
  margin-bottom: 0;
  -moz-box-sizing: border-box;
}

:table {
  display: table;
}

==================================================

...because:

  border-spacing is inherited by default
  border-collapse is inherited by default
  margin-top has '0' as the initial value anyway
  margin-bottom has '0' as the initial value anyway

I'm not sure about the -moz-box-sizing declaration, will :table ever be given
an explicit width? If not, then the declaration is moot, no?

You can see the effect of this change at:
   http://www.hixie.ch/tests/adhoc/css/box/table/001.xml
Without the fix, there is lots of red. With the fix, there is only a thin border
of red (caused by the bug which is depending on this bug).

Comment 1

[karnaze (gone)]

Moving to m1.0

Comment 2

[Amarendra Hanumanula]

QA contact update

Comment 3

[Evan Jones]

Correct me if I am wrong, but the CSS2 specification requires the following
initial values:

table {
    border-spacing: 0;
    border-collapse: collapse;
}

See http://www.w3.org/TR/REC-CSS2/tables.html#propdef-border-collapse

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The CSS2 spec also allows for a UA stylesheet to specify the default layout of
any markup language.

Comment 5

[Hixie (not reading bugmail)]

Evan: that's non-normative.

I would like to change my previous proposal to include !important in the rule
for :table. Ideally, of course, we wouldn't have to resolve psuedo-style on
these anonymous elements at all and those frames would just "know" that they
are table frames...

Is there any reason _not_ to fix the bug as proposed?

Comment 6

[Hixie (not reading bugmail)]

Reassigning to hyatt as per discussion.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron on Ian's proposal.

We should investigate sometime whether our default values for 'border-collapse'
and 'empty-cells' are correct.

Comment 8

[basic]

what is the status on this?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, I'll take this and get it in.

Comment 10

[Christopher Hoess (gone)]

Adding keywords...

Comment 11

[basic]

setting platform/os to all

Comment 12

[basic]

Attachment: Hixie's patch as an attachment

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 52089 [details] [diff] [review]
Hixie's patch as an attachment

r=dbaron

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Although, could someone double-check that the changes to -moz-box-sizing and to
border-collapse don't cause problems?

Comment 15

[Hixie (not reading bugmail)]

I can guarentee that the change to border-collapse will have no effect. :-)
Not sure about -moz-box-sizing though.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: safer patch

Comment 17

[Marc Attinasi]

Comment on attachment 56975 [details] [diff] [review]
safer patch

sr=attinasi

Comment 18

[Marc Attinasi]

I'm curious about how :table is used. I thought it was used to create an
anonymous table in case, for example, a rowgroup is inserted into some non-table
container. In that case, I would expect that table and :table should have the
same style properties. From looking at Ian's testcase, it seems we use :table
for arbitrary elements with display:table - is this right? Is there a disconnect
between these two uses?

Comment 19

[Hixie (not reading bugmail)]

Comment on attachment 56975 [details] [diff] [review]
safer patch

r=hixie

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The :table pseudo-element is used in one place,
nsCSSFrameConstructor::CreatePseudoTableFrame.  Presumably that means it's only
used for anonymous content, although I could imagine there might be some cases
where we construct unneeded anonymous content (missing row groups?).

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-11-10 17:35 PDT.

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, in Ian's testcase, the table frame is an anonymous table object --
nothing has 'display: table' -- it's a table-row inside a float.